ai_ml_operations/chat_web_app
2
0 Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix beta build: satisfy MessageContext hook deps #140

Merged
westfarn merged 1 commits from fix/139-message-context-hook-deps into master 2026-10-25 06:20:01 -07:00
Conversation 0 Commits 1 Files Changed 2
+30 -7
westfarn commented 2026-10-25 06:19:20 -07:00
Owner
Copy link
Copy source

Summary

  • Closes #139.
  • Deploy Beta run 1025 failed npm run build:beta on ai-server-4080 because CI=true turns react-hooks/exhaustive-deps warnings into errors.
  • GetConversationDetails is a useCallback and is listed on the post-stream refetch, the selected-conversation effect, and the reconnect effect. setConversationDetails stays stable, so those effects still run only when their real inputs change.
  • Adds a project rule to lint changed llm-fe files with warnings as errors before pushing a merge request.

Test plan

  • CI=true ./node_modules/.bin/eslint --max-warnings 0 src/llm-fe/contexts/MessageContext.tsx
  • MessageContext.test.tsx and MessageContext.order.test.tsx (8 passed)
  • Deploy Beta build:beta succeeds on ai-server-4080 after merge
## Summary - Closes #139. - [Deploy Beta run 1025](https://git.aimloperations.com/ai_ml_operations/chat_web_app/actions/runs/1025/jobs/1743) failed `npm run build:beta` on `ai-server-4080` because `CI=true` turns `react-hooks/exhaustive-deps` warnings into errors. - `GetConversationDetails` is a `useCallback` and is listed on the post-stream refetch, the selected-conversation effect, and the reconnect effect. `setConversationDetails` stays stable, so those effects still run only when their real inputs change. - Adds a project rule to lint changed `llm-fe` files with warnings as errors before pushing a merge request. ## Test plan - [x] `CI=true ./node_modules/.bin/eslint --max-warnings 0 src/llm-fe/contexts/MessageContext.tsx` - [x] `MessageContext.test.tsx` and `MessageContext.order.test.tsx` (8 passed) - [ ] Deploy Beta `build:beta` succeeds on `ai-server-4080` after merge
westfarn added 1 commit 2026-10-25 06:19:20 -07:00
Fix beta build: satisfy MessageContext hook deps.
Unit Tests / test (pull_request) Successful in 13s
Details
5fdc1377a0 
CI=true turns the exhaustive-deps warnings into a failed build:beta on the deploy runner.
Closes #139.
westfarn merged commit 608fb37413 into master 2026-10-25 06:20:01 -07:00
westfarn deleted branch fix/139-message-context-hook-deps 2026-10-25 06:20:01 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
twestfall westfarn (Ryan Westfall)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ai_ml_operations/chat_web_app#140