ai_ml_operations/chat_web_app
2
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

Add cookie / analytics consent banner polish (#37) #44

Merged
westfarn merged 1 commits from feat/37-analytics-consent-banner into master 2026-07-27 08:22:39 -07:00
Conversation 0 Commits 1 Files Changed 6
+54 -23
westfarn commented 2026-07-27 07:02:41 -07:00
Owner
Copy Link
Copy Source

Summary

Closes #37.

Core banner + consent helpers already landed with #42 (AnalyticsConsentBanner, context, page views always on / custom events gated).

This PR finishes the ticket:

  • Versioned localStorage key hesychia_analytics_consent_v1 (migrates legacy hesychia_analytics_consent)
  • Banner links to /terms_of_service/#analytics (pair with #43 for public ToS + analytics section)
  • README notes on consent policy / storage

Test plan

  • Prod/beta build: first visit shows Accept / Decline banner
  • Choice persists across reload; banner stays hidden
  • Decline → page views still load; custom events stay off (see #36)
  • Accept → custom events allowed once #36 call sites ship
  • Banner Terms link opens analytics section (after #43 merged)
  • npm run test:ci -- --testPathPattern='analyticsConsent|AnalyticsConsentBanner|analytics.test'
## Summary Closes #37. Core banner + consent helpers already landed with [#42](https://git.aimloperations.com/ai_ml_operations/chat_web_app/pulls/42) (`AnalyticsConsentBanner`, context, page views always on / custom events gated). This PR finishes the ticket: - Versioned `localStorage` key `hesychia_analytics_consent_v1` (migrates legacy `hesychia_analytics_consent`) - Banner links to `/terms_of_service/#analytics` (pair with [#43](https://git.aimloperations.com/ai_ml_operations/chat_web_app/pulls/43) for public ToS + analytics section) - README notes on consent policy / storage ## Test plan - [ ] Prod/beta build: first visit shows Accept / Decline banner - [ ] Choice persists across reload; banner stays hidden - [ ] Decline → page views still load; custom events stay off (see #36) - [ ] Accept → custom events allowed once #36 call sites ship - [ ] Banner Terms link opens analytics section (after #43 merged) - [ ] `npm run test:ci -- --testPathPattern='analyticsConsent|AnalyticsConsentBanner|analytics.test'`
westfarn added 1 commit 2026-07-27 07:51:35 -07:00
Harden analytics consent banner storage and ToS deep-link (#37)
Unit Tests / test (pull_request) Successful in 13s
Details
9c814dcc60 
Version consent in localStorage (v1 + legacy migrate), point banner at Terms analytics section, and document the always-on vs optional policy. Banner/provider shipped in #42.
westfarn force-pushed feat/37-analytics-consent-banner from 11b5734812 to 9c814dcc60 2026-07-27 07:51:35 -07:00 Compare
westfarn merged commit 1c9e04cf86 into master 2026-07-27 08:22:39 -07:00
westfarn deleted branch feat/37-analytics-consent-banner 2026-07-27 08:22:39 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
twestfall westfarn (Ryan Westfall)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ai_ml_operations/chat_web_app#44