diff --git a/site/monica_site/static/css/portal.css b/site/monica_site/static/css/portal.css index 949ff9d..10834da 100644 --- a/site/monica_site/static/css/portal.css +++ b/site/monica_site/static/css/portal.css @@ -362,6 +362,29 @@ body.portal { .plain-list { margin: 0 0 12px; padding-left: 18px; } .plain-list li { margin-bottom: 6px; } .check-row { display: flex; align-items: center; gap: 8px; font-size: 14px; } +.check-row.account-pick { align-items: flex-start; } +.account-pick-copy { + min-width: 0; + overflow-wrap: anywhere; + word-break: break-word; +} +.account-pick-copy strong { display: block; font-weight: 600; } +.account-rename { + display: flex; + gap: 6px; + align-items: center; + flex-wrap: wrap; +} +.account-rename input[type="text"] { + flex: 1; + min-width: 160px; + max-width: 100%; + padding: 8px 10px; + border: 1px solid var(--monica-border); + font: inherit; + background: #fff; + box-sizing: border-box; +} .row-warn td { background: #fffbeb; } .auth-alert { background: #fff7ed; diff --git a/site/social/models.py b/site/social/models.py index 2b62649..6b7c77c 100644 --- a/site/social/models.py +++ b/site/social/models.py @@ -3,6 +3,29 @@ from django.db import models from core.models import TimeStampedModel, UUIDPrimaryKeyModel +_GENERIC_ACCOUNT_LABELS = frozenset( + { + "linkedin member", + "instagram account", + "facebook page", + } +) + + +def is_generic_account_label(label: str) -> bool: + """True when OAuth left a placeholder or unreadable name.""" + text = (label or "").strip() + if not text: + return True + lowered = text.lower() + if lowered in _GENERIC_ACCOUNT_LABELS: + return True + if lowered.startswith("page ") and text.split()[-1].isdigit(): + return True + if text.startswith("urn:"): + return True + return False + class Platform(models.TextChoices): FACEBOOK = "facebook", "Facebook" @@ -54,6 +77,22 @@ class SocialAccount(UUIDPrimaryKeyModel, TimeStampedModel): def __str__(self) -> str: return f"{self.platform}: {self.label}" + @property + def display_name(self) -> str: + return (self.label or "").strip() or self.get_platform_display() + + @staticmethod + def resolve_label(existing: "SocialAccount | None", incoming: str) -> str: + """Keep a custom rename; otherwise take the OAuth name.""" + incoming = (incoming or "").strip()[:120] + if existing is not None and not is_generic_account_label(existing.label): + return existing.label + if incoming: + return incoming + if existing and existing.label: + return existing.label + return "Account" + class SocialPost(UUIDPrimaryKeyModel, TimeStampedModel): class Status(models.TextChoices): diff --git a/site/social/templates/social/account_list.html b/site/social/templates/social/account_list.html index 94b143e..14085fe 100644 --- a/site/social/templates/social/account_list.html +++ b/site/social/templates/social/account_list.html @@ -137,8 +137,18 @@ {% for account in accounts %} - {{ account.label }}
- {{ account.external_id }} +
+ {% csrf_token %} + + + + +
+ {% if account.external_id %} + {{ account.external_id }} + {% endif %} diff --git a/site/social/templates/social/composer.html b/site/social/templates/social/composer.html index 38127c9..ab2d09f 100644 --- a/site/social/templates/social/composer.html +++ b/site/social/templates/social/composer.html @@ -116,34 +116,35 @@
{% for account in accounts %} -
- - -
-
- + +
Needed only if you click Schedule. Leave blank to Send now.
- + + +
@@ -199,8 +200,8 @@ var previewBody = document.getElementById('preview-body'); var content = document.getElementById('preview-content'); var previewMedia = document.getElementById('preview-media'); - var mode = document.getElementById('id_publish_mode'); var when = document.getElementById('id_scheduled_for'); + var composeForm = document.getElementById('social-compose'); var mediaInput = document.getElementById('id_media'); var mediaJson = document.getElementById('id_media_json'); var thumbs = document.getElementById('media-thumbs'); @@ -296,9 +297,14 @@ previewBody.hidden = !hasContent; } - function syncWhen() { - if (!mode || !when) return; - when.disabled = mode.value !== 'schedule'; + function requireScheduleTime(event) { + var submitter = event.submitter; + var action = submitter && submitter.name === 'action' ? submitter.value : ''; + if (action !== 'schedule') return; + if (when && when.value) return; + event.preventDefault(); + if (when) when.focus(); + window.alert('Pick a date and time to schedule, or choose Send now.'); } function validateBeforeUpload(file) { @@ -363,7 +369,7 @@ bodyEl.addEventListener('keyup', syncPreview); bodyEl.addEventListener('change', syncPreview); } - if (mode) mode.addEventListener('change', syncWhen); + if (composeForm) composeForm.addEventListener('submit', requireScheduleTime); var generateForm = document.querySelector('form input[name=action][value=generate]')?.form; if (generateForm) { @@ -378,7 +384,6 @@ syncMediaField(); renderThumbs(); syncPreview(); - syncWhen(); })(); {% endblock %} diff --git a/site/social/templates/social/post_detail.html b/site/social/templates/social/post_detail.html index 620e21f..d3040eb 100644 --- a/site/social/templates/social/post_detail.html +++ b/site/social/templates/social/post_detail.html @@ -38,7 +38,12 @@ {% for target in post.targets.all %} - {{ target.account.label }} + + {{ target.account.display_name }} + {% if target.account.external_id %} +
{{ target.account.external_id }} + {% endif %} + {{ target.get_platform_display }} {{ target.get_status_display }} diff --git a/site/social/tests.py b/site/social/tests.py new file mode 100644 index 0000000..01e6db4 --- /dev/null +++ b/site/social/tests.py @@ -0,0 +1,182 @@ +from unittest.mock import patch + +from django.contrib.auth import get_user_model +from django.test import Client, TestCase +from django.urls import reverse + +from social.models import ( + Platform, + SocialAccount, + SocialPost, + is_generic_account_label, +) + + +class AccountLabelTests(TestCase): + def test_generic_placeholders(self): + self.assertTrue(is_generic_account_label("")) + self.assertTrue(is_generic_account_label("LinkedIn member")) + self.assertTrue(is_generic_account_label("Instagram account")) + self.assertTrue(is_generic_account_label("Page 123456")) + self.assertTrue(is_generic_account_label("urn:li:person:abc")) + self.assertFalse(is_generic_account_label("Monica Dhillon")) + self.assertFalse(is_generic_account_label("@mkdrealtor")) + + def test_resolve_keeps_custom_name(self): + existing = SocialAccount( + platform=Platform.LINKEDIN, + label="Monica (personal)", + external_id="urn:li:person:abc", + ) + self.assertEqual( + SocialAccount.resolve_label(existing, "LinkedIn member"), + "Monica (personal)", + ) + + def test_resolve_replaces_generic(self): + existing = SocialAccount( + platform=Platform.LINKEDIN, + label="LinkedIn member", + external_id="urn:li:person:abc", + ) + self.assertEqual( + SocialAccount.resolve_label(existing, "Monica Dhillon"), + "Monica Dhillon", + ) + + +class SocialComposerTests(TestCase): + def setUp(self): + User = get_user_model() + self.user = User.objects.create_user( + username="composer", password="test-pass-123" + ) + self.client = Client() + self.client.login(username="composer", password="test-pass-123") + self.account = SocialAccount.objects.create( + platform=Platform.LINKEDIN, + label="LinkedIn member", + external_id="urn:li:person:abc123", + is_active=True, + owner=self.user, + ) + + def test_composer_shows_send_now_and_full_name(self): + response = self.client.get(reverse("social:composer")) + self.assertEqual(response.status_code, 200) + self.assertContains(response, "Send now") + self.assertContains(response, "Schedule") + self.assertContains(response, "LinkedIn member") + self.assertContains(response, "urn:li:person:abc123") + self.assertNotContains(response, "Save / publish") + + def test_send_now_queues_without_schedule(self): + mock_task = patch("social.views.publish_social_post").start() + self.addCleanup(patch.stopall) + response = self.client.post( + reverse("social:composer"), + { + "body": "Open house Saturday", + "account_ids": [str(self.account.pk)], + "action": "send_now", + }, + ) + post = SocialPost.objects.get() + self.assertEqual(response.status_code, 302) + self.assertEqual( + response.url, reverse("social:post_detail", kwargs={"pk": post.pk}) + ) + self.assertEqual(post.status, SocialPost.Status.QUEUED) + self.assertIsNotNone(post.scheduled_for) + self.assertEqual(post.targets.count(), 1) + mock_task.enqueue.assert_called_once_with(post_id=str(post.pk)) + + def test_schedule_requires_datetime(self): + response = self.client.post( + reverse("social:composer"), + { + "body": "Open house Saturday", + "account_ids": [str(self.account.pk)], + "action": "schedule", + }, + ) + self.assertEqual(response.status_code, 200) + self.assertContains(response, "Pick a schedule date/time, or choose Send now.") + self.assertFalse(SocialPost.objects.exists()) + + def test_schedule_with_datetime(self): + response = self.client.post( + reverse("social:composer"), + { + "body": "Open house Saturday", + "account_ids": [str(self.account.pk)], + "action": "schedule", + "scheduled_for": "2026-08-10T09:30", + }, + ) + post = SocialPost.objects.get() + self.assertEqual(response.status_code, 302) + self.assertEqual(post.status, SocialPost.Status.SCHEDULED) + self.assertIsNotNone(post.scheduled_for) + + def test_save_draft(self): + response = self.client.post( + reverse("social:composer"), + { + "body": "Draft caption", + "action": "save", + }, + ) + post = SocialPost.objects.get() + self.assertEqual(response.status_code, 302) + self.assertEqual(post.status, SocialPost.Status.DRAFT) + + +class SocialAccountRenameTests(TestCase): + def setUp(self): + User = get_user_model() + self.user = User.objects.create_user( + username="renamer", password="test-pass-123" + ) + self.client = Client() + self.client.login(username="renamer", password="test-pass-123") + self.account = SocialAccount.objects.create( + platform=Platform.FACEBOOK, + label="Page 999", + external_id="999", + is_active=True, + owner=self.user, + ) + + def test_accounts_page_shows_rename_field(self): + response = self.client.get(reverse("social:account_list")) + self.assertEqual(response.status_code, 200) + self.assertContains(response, 'name="label"') + self.assertContains(response, "Page 999") + self.assertContains(response, "Rename") + + def test_rename_updates_label(self): + response = self.client.post( + reverse("social:account_list"), + { + "action": "rename", + "account_id": str(self.account.pk), + "label": "Monica Dhillon Realty", + }, + ) + self.assertEqual(response.status_code, 302) + self.account.refresh_from_db() + self.assertEqual(self.account.label, "Monica Dhillon Realty") + + def test_rename_rejects_blank(self): + response = self.client.post( + reverse("social:account_list"), + { + "action": "rename", + "account_id": str(self.account.pk), + "label": " ", + }, + ) + self.assertEqual(response.status_code, 302) + self.account.refresh_from_db() + self.assertEqual(self.account.label, "Page 999") diff --git a/site/social/views.py b/site/social/views.py index bdbf83e..2be24b3 100644 --- a/site/social/views.py +++ b/site/social/views.py @@ -162,6 +162,17 @@ def account_list(request): if request.method == "POST": action = (request.POST.get("action") or "connect").strip() + if action == "rename": + pk = request.POST.get("account_id") + account = get_object_or_404(SocialAccount, pk=pk) + label = (request.POST.get("label") or "").strip()[:120] + if not label: + messages.error(request, "Enter a display name.") + return redirect("social:account_list") + account.label = label + account.save(update_fields=["label", "updated_at"]) + messages.success(request, f"Renamed account to {account.label}.") + return redirect("social:account_list") if action == "disconnect": pk = request.POST.get("account_id") account = get_object_or_404(SocialAccount, pk=pk) @@ -361,11 +372,14 @@ def linkedin_oauth_callback(request): profile = linkedin_fetch_member_profile(token_payload["access_token"]) author_urn = profile["author_urn"] blob = linkedin_token_blob_from_oauth(token_payload, author_urn=author_urn) + existing = SocialAccount.objects.filter( + platform=Platform.LINKEDIN, external_id=author_urn + ).first() account, created = SocialAccount.objects.update_or_create( platform=Platform.LINKEDIN, external_id=author_urn, defaults={ - "label": profile["label"], + "label": SocialAccount.resolve_label(existing, profile["label"]), "encrypted_tokens": encrypt_tokens(json.dumps(blob)), "is_active": True, "owner": request.user, @@ -473,11 +487,14 @@ def meta_oauth_complete(request): ) for page in ig_pages: blob = instagram_token_blob(page, user_token=user_token) + existing = SocialAccount.objects.filter( + platform=Platform.INSTAGRAM, external_id=blob["ig_user_id"] + ).first() account, created = SocialAccount.objects.update_or_create( platform=Platform.INSTAGRAM, external_id=blob["ig_user_id"], defaults={ - "label": blob["label"], + "label": SocialAccount.resolve_label(existing, blob["label"]), "encrypted_tokens": encrypt_tokens(json.dumps(blob)), "is_active": True, "owner": request.user, @@ -487,12 +504,15 @@ def meta_oauth_complete(request): else: for page in pages: blob = facebook_token_blob(page, user_token=user_token) - label = (page.get("name") or "").strip() or f"Page {page['id']}" + incoming_label = (page.get("name") or "").strip() or f"Page {page['id']}" + existing = SocialAccount.objects.filter( + platform=Platform.FACEBOOK, external_id=str(page["id"]) + ).first() account, created = SocialAccount.objects.update_or_create( platform=Platform.FACEBOOK, external_id=str(page["id"]), defaults={ - "label": label, + "label": SocialAccount.resolve_label(existing, incoming_label), "encrypted_tokens": encrypt_tokens(json.dumps(blob)), "is_active": True, "owner": request.user, @@ -525,7 +545,7 @@ def composer(request): form = { "body": "", "prompt": "", - "publish_mode": "schedule", + "publish_mode": "now", "scheduled_for": "", "account_ids": [], "media_json": "[]", @@ -536,11 +556,17 @@ def composer(request): if request.method == "POST": form["body"] = (request.POST.get("body") or "").strip() form["prompt"] = (request.POST.get("prompt") or "").strip() - form["publish_mode"] = (request.POST.get("publish_mode") or "schedule").strip() + form["publish_mode"] = (request.POST.get("publish_mode") or "now").strip() form["scheduled_for"] = request.POST.get("scheduled_for") or "" form["account_ids"] = request.POST.getlist("account_ids") form["media_json"] = (request.POST.get("media_json") or "[]").strip() or "[]" action = (request.POST.get("action") or "save").strip() + if action == "send_now": + form["publish_mode"] = "now" + elif action == "schedule": + form["publish_mode"] = "schedule" + elif action == "save": + form["publish_mode"] = "draft" if action == "generate" and form["prompt"]: try: @@ -548,7 +574,7 @@ def composer(request): form["body"] = draft except OllamaError as exc: error = str(exc) - elif action in {"save", "publish"}: + elif action in {"save", "publish", "send_now", "schedule"}: media_items: list = [] try: media_items = parse_media_json(form["media_json"]) @@ -571,7 +597,7 @@ def composer(request): error = str(exc) else: if not scheduled_for: - error = "Pick a schedule date/time, or choose Publish now." + error = "Pick a schedule date/time, or choose Send now." else: status = SocialPost.Status.SCHEDULED elif form["publish_mode"] == "now": @@ -614,7 +640,7 @@ def composer(request): publish_social_post.enqueue(post_id=str(post.pk)) messages.success( request, - "Post queued for publishing to selected accounts.", + "Post sent — queued for publishing to selected accounts.", ) elif status == SocialPost.Status.SCHEDULED: messages.success(