ai_ml_operations/scha
2
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

Isolate CI/deploy tests from production DATABASE_URL #24

Merged
westfarn merged 1 commits from fix/ci-isolated-test-db into master 2026-07-14 05:00:01 -07:00
Conversation 0 Commits 1 Files Changed 5
+29 -6
westfarn commented 2026-07-14 04:55:40 -07:00
Owner
Copy Link
Copy Source

Summary

  • Root cause: docker-compose.yml used ${DATABASE_URL:-…}, so the Act runner’s host/prod DATABASE_URL was interpolated into the web service. Containerized deploy tests then ran against shared Postgres instead of the bundled compose db.
  • Stop reading host DATABASE_URL in compose (use COMPOSE_DATABASE_URL override only).
  • Deploy docker step: unset DB secrets, dedicated compose project name, up --wait db, force test DATABASE_URL to postgres://scha:scha@db:5432/scha, down -v on exit (ephemeral DB).
  • Clear DATABASE_URL/DB_HOST in unittests.yml / ci.yml so host sqlite-fallback tests cannot hit prod either.

Test plan

  • Merge to master and watch Unit Tests + Deploy docker job.
  • Confirm docker step connects only to compose db (no traffic/errors against 10.0.0.230).
  • Confirm docker compose -p scha-ci-<sha> … volumes cleaned after job (down -v).
  • Local: docker compose up --build still works with bundled Postgres.
## Summary - Root cause: `docker-compose.yml` used `${DATABASE_URL:-…}`, so the Act runner’s host/`prod` `DATABASE_URL` was interpolated into the web service. Containerized deploy tests then ran against shared Postgres instead of the bundled compose `db`. - Stop reading host `DATABASE_URL` in compose (use `COMPOSE_DATABASE_URL` override only). - Deploy docker step: unset DB secrets, dedicated compose project name, `up --wait db`, force test `DATABASE_URL` to `postgres://scha:scha@db:5432/scha`, `down -v` on exit (ephemeral DB). - Clear `DATABASE_URL`/`DB_HOST` in `unittests.yml` / `ci.yml` so host sqlite-fallback tests cannot hit prod either. ## Test plan - [ ] Merge to `master` and watch Unit Tests + Deploy docker job. - [ ] Confirm docker step connects only to compose `db` (no traffic/errors against `10.0.0.230`). - [ ] Confirm `docker compose -p scha-ci-<sha> …` volumes cleaned after job (`down -v`). - [ ] Local: `docker compose up --build` still works with bundled Postgres.
westfarn added 1 commit 2026-07-14 04:55:40 -07:00
Isolate CI/deploy tests from host/prod DATABASE_URL.
CI / test (pull_request) Successful in 3s
Details
Unit Tests / test (pull_request) Successful in 3s
Details
629d337380 
Compose was interpolating ${DATABASE_URL} from the Act runner, so containerized tests could hit shared Postgres. Use COMPOSE_DATABASE_URL, an ephemeral compose project with down -v, and clear DB env in unit-test workflows.
westfarn merged commit 0b76b781e3 into master 2026-07-14 05:00:01 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
twestfall westfarn (Ryan Westfall)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ai_ml_operations/scha#24