rejectattr(enabled) breaks deploy when host_apps omit the key #35

New Issue

2026-09-16T08:17:39-07:00

westfarn commented

2026-09-16 08:17:39 -07:00

#33 made deploy skip host_apps.enabled: false so a stopped app cannot come back via CI. The filter is:

deploy_targets: "{{ matching_host_apps | rejectattr('enabled', 'equalto', false) | list }}"

Jinja rejectattr('enabled', …) requires the key on every dict. Almost every host_apps row omits enabled (omit = enabled). That is the documented default.

Symptom: every --app deploy dies on all webservers before git/compose:

object of type 'dict' has no attribute 'enabled'
Origin: roles/app-deploy/tasks/main.yml:40

Hit on url_shortening_service beta (69d8b3e). Same bug on the skip-debug selectattr('enabled', …) loop and roles/web-static/tasks/main.yml.

Do: treat missing enabled as true. Keep enabled: false (print_forge) skipped. Do not add enabled: true to every inventory row.

`#33` made deploy skip `host_apps.enabled: false` so a stopped app cannot come back via CI. The filter is: ```yaml deploy_targets: "{{ matching_host_apps | rejectattr('enabled', 'equalto', false) | list }}" ``` Jinja `rejectattr('enabled', …)` requires the key on **every** dict. Almost every `host_apps` row omits `enabled` (omit = enabled). That is the documented default. **Symptom:** every `--app` deploy dies on all webservers before git/compose: ``` object of type 'dict' has no attribute 'enabled' Origin: roles/app-deploy/tasks/main.yml:40 ``` Hit on `url_shortening_service` beta (`69d8b3e`). Same bug on the skip-debug `selectattr('enabled', …)` loop and `roles/web-static/tasks/main.yml`. **Do:** treat missing `enabled` as true. Keep `enabled: false` (print_forge) skipped. Do not add `enabled: true` to every inventory row.

westfarn referenced this issue from a commit

2026-09-16 08:20:54 -07:00

Treat omitted host_apps.enabled as true so deploy works (#35).

westfarn referenced a pull request that will close this issue

2026-09-16 08:21:00 -07:00

Treat omitted host_apps.enabled as true #36

westfarn closed this issue

2026-09-16 08:21:29 -07:00

westfarn referenced this issue from a commit

2026-09-16 08:21:31 -07:00

Treat omitted host_apps.enabled as true (#36)

Sign in to join this conversation.