ai_ml_operations/server-infra
2
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Treat omitted host_apps.enabled as true #36

Merged
westfarn merged 1 commits from issue-35-enabled-omit-default into master 2026-09-16 08:21:29 -07:00
Conversation 0 Commits 1 Files Changed 3
+26 -4
westfarn commented 2026-09-16 08:21:00 -07:00
Owner
Copy Link
Copy Source

Closes #35.

Summary

  • #33 used Jinja rejectattr('enabled', 'equalto', false) to skip stopped apps. That filter requires the key, so every host_apps row that omits enabled (the documented default) crashed deploy on all webservers before git/compose.
  • Filter with item.enabled | default(true) instead, in app-deploy and web-static. print_forge (enabled: false) still skipped. url_shortening_service and every other omitted-key row deploy again.

Test plan

  • ansible-playbook playbooks/deploy-apps.yml --syntax-check
  • Redeploy url_shortening_service beta: deploy.sh --app url_shortening_service --env beta --ref <sha>
  • Confirm print_forge is still not started (no compose up on 8007/8019)
Closes #35. ## Summary - `#33` used Jinja `rejectattr('enabled', 'equalto', false)` to skip stopped apps. That filter **requires** the key, so every `host_apps` row that omits `enabled` (the documented default) crashed deploy on all webservers before git/compose. - Filter with `item.enabled | default(true)` instead, in `app-deploy` and `web-static`. `print_forge` (`enabled: false`) still skipped. `url_shortening_service` and every other omitted-key row deploy again. ## Test plan - [ ] `ansible-playbook playbooks/deploy-apps.yml --syntax-check` - [ ] Redeploy `url_shortening_service` beta: `deploy.sh --app url_shortening_service --env beta --ref <sha>` - [ ] Confirm `print_forge` is still not started (no compose up on 8007/8019)
westfarn added 1 commit 2026-09-16 08:21:00 -07:00
Treat omitted host_apps.enabled as true so deploy works (#35).
Sync runner checkout / sync (pull_request) Successful in 7s
Details
08ea6dfb08 
rejectattr('enabled') raised on every row that omitted the key, which
blocked all app deploys after #33 — including url_shortening_service.
westfarn merged commit 658152088e into master 2026-09-16 08:21:29 -07:00
westfarn deleted branch issue-35-enabled-omit-default 2026-09-16 08:21:29 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
twestfall westfarn (Ryan Westfall)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ai_ml_operations/server-infra#36